Skip to content

HtmlUnitNekoDOMBuilder: Better handling of <form></form> enclosures - #536

Closed
atnak wants to merge 1 commit into
HtmlUnit:masterfrom
atnak:hotfix_nakagawa_form_enclosures
Closed

atnak wants to merge 1 commit into
HtmlUnit:masterfrom
atnak:hotfix_nakagawa_form_enclosures

Conversation

@atnak

@atnak atnak commented Dec 21, 2022 •

Copy link
Copy Markdown
Contributor

wip PR

Attempting to merge local fixes to upstream because HtmlUnitNekoDOMBuilder is getting painful to merge

Fixes for https://sourceforge.net/p/htmlunit/bugs/1630/

TODO:

  • refactor addNodeToRightParent() a bit
  • add a few more fixes for table handling in addNodeToRightParent()
  • consider how to give tests

@rbri

rbri commented Dec 22, 2022

Copy link
Copy Markdown
Member

@atnak i guess i have to wait for more commits here before having a look - right?

regarding the tests i guess you can use something from com.gargoylesoftware.htmlunit.html.parser as template.

@rbri

rbri commented Dec 22, 2022

Copy link
Copy Markdown
Member

and also thanks for the contribution

@atnak atnak closed this Dec 28, 2022
@atnak
atnak deleted the hotfix_nakagawa_form_enclosures branch December 28, 2022 14:48
@atnak

atnak commented Dec 28, 2022

Copy link
Copy Markdown
Contributor Author

Closed for #538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants