Skip to content

Extract VST into VirtualTrees.StringTree.pas, leave VirtualTrees.pas as aggregate unit #1210

Description

@Fr0sT-Brutal

Just an idea that won't change things much but will continue logical separation of various tree implementations.
As a downside - this probably will require a new entry in all packages

Activity

  1. joachimmarder commented on Aug 13, 2023

    @joachimmarder
    Contributor

    I like the idea, although I think we already have enough breaking changes in the upcoming V8.

  2. added
    Open for DiscussionThere are several possibilites to address the issue and anyone is invited for comments.
    Pull Requests InvitedThere are no current plans to address the issue, but we would be happy if someone supplies a PR.
    on Aug 13, 2023
  3. Fr0sT-Brutal commented on Aug 21, 2023

    @Fr0sT-Brutal
    ContributorAuthor

    Well, if TVST will be redeclared in old unit, this won't be a breaking change AFAICS. Now VirtualTrees.pas contains only a few original public declarations as most of declarations are aliases. So just some more aliases. I'll make PR with this change for you to estimate required changes.

  4. joachimmarder commented on Aug 22, 2023

    @joachimmarder
    Contributor

    Maybe I should have left out the word "breaking". I have no intention to make this change myself for V8.0, but feel free to send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking ChangeOpen for DiscussionThere are several possibilites to address the issue and anyone is invited for comments.Pull Requests InvitedThere are no current plans to address the issue, but we would be happy if someone supplies a PR.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions