Skip to content

Do not mix signed an unsiged types, use integer consequently #892

Description

@joachimmarder

There are code lines that try to work around the singed and unsigned problems like this:
Inc(Integer(Run.TotalCount), Difference);

TotalCount is unsigned while Difference is signed. Code would be more managable and more solid if we would use unsigned values consistently.

This could also help the port to FireMonkey, see #839.

Activity

  1. added
    Open for DiscussionThere are several possibilites to address the issue and anyone is invited for comments.
    RefactoringInternal code changes that improve architecture
    on Apr 1, 2019
  2. added this to the V8.0 milestone on Apr 1, 2019
  3. Fr0sT-Brutal commented on Aug 23, 2019

    @Fr0sT-Brutal
    Contributor

    Hmm, weird, I have no warnings at all when I build packages neither in XE2 nor 10.1

  4. joachimmarder commented on Aug 23, 2019

    @joachimmarder
    ContributorAuthor

    I have no warnings at all

    Sure, warnings are suppressed by the hard casts.

  5. joachimmarder commented on Feb 12, 2023

    @joachimmarder
    ContributorAuthor

    Since the initial port to Firemonkey has made a lot of progress, I am closing this issue. There is no more actual problem to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking ChangeOpen for DiscussionThere are several possibilites to address the issue and anyone is invited for comments.RefactoringInternal code changes that improve architecture

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions