Skip to content

Set [email protected] and [email protected] - #1992

Merged
climbfuji merged 8 commits into
developfrom
AlexanderRichert-NOAA-patch-2
May 27, 2026
Merged

Set [email protected] and [email protected]#1992
climbfuji merged 8 commits into
developfrom
AlexanderRichert-NOAA-patch-2

Conversation

@AlexanderRichert-NOAA

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR updates the bufr package version to 12.3.0. Compared with v12.2.0, it's a lot of bug fixes, as well as improvements to error handling that are not expected to affect current behavior. ufbin3 and nevn subprograms are also removed. It also updates to [email protected] to resolve segfault problem for GSI (#1938).

Dependencies

JCSDA/spack-packages#61

Issues addressed

Fixes #1938

Applications affected

GSI, JEDI, IODA, Global Workflow, UFS_UTILS

Systems affected

all

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged

@climbfuji

climbfuji commented Apr 24, 2026

Copy link
Copy Markdown
Collaborator

CI error

==> Error: Version requirement 12.3.0 on bufr for bufr cannot match any known version from package.py or externals"

@climbfuji climbfuji moved this to In Progress in spack-stack-2.1.x (2026 Q1) May 12, 2026
@climbfuji

climbfuji commented May 13, 2026

Copy link
Copy Markdown
Collaborator

@AlexanderRichert-NOAA Do we need this + accompanying spack-packages change in release/2.1?

@AlexanderRichert-NOAA

AlexanderRichert-NOAA commented May 13, 2026

Copy link
Copy Markdown
Collaborator Author

That's the plan yes, this has been on my back burner the last couple weeks. I'll try to get this and gsi-ncdiag updated today/tomorrow.

@AlexanderRichert-NOAA AlexanderRichert-NOAA mentioned this pull request May 26, 2026
Closed
3 of 8 tasks
@AlexanderRichert-NOAA AlexanderRichert-NOAA changed the title Update bufr package version from 12.1.0 to 12.3.0 Set [email protected] and [email protected] May 26, 2026
@AlexanderRichert-NOAA
AlexanderRichert-NOAA marked this pull request as ready for review May 26, 2026 18:38
@climbfuji

climbfuji commented May 26, 2026

Copy link
Copy Markdown
Collaborator

@AlexanderRichert-NOAA New hash for spack-packages is JCSDA/spack-packages@3d0131d

@AlexanderRichert-NOAA

AlexanderRichert-NOAA commented May 26, 2026

Copy link
Copy Markdown
Collaborator Author

good to go

@climbfuji climbfuji self-assigned this May 27, 2026
@climbfuji
climbfuji self-requested a review May 27, 2026 02:46
climbfuji
climbfuji approved these changes May 27, 2026
View reviewed changes

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. We need to cherry-pick the necessary changes from develop / spack-stack-dev and merge them into the release/2.1 branches. Do you have time to do that after this PR merges?

@climbfuji
climbfuji enabled auto-merge (squash) May 27, 2026 02:48
@AlexanderRichert-NOAA

AlexanderRichert-NOAA commented May 27, 2026

Copy link
Copy Markdown
Collaborator Author

Here's the spack-packages PR with the gsi-ncdiag update for release/2.1: JCSDA/spack-packages#62
I can do the PR for spack-stack release/2.1 after we merge that, unless you prefer to retest with the updated submodule.

@mathomp4 mathomp4 mentioned this pull request May 27, 2026
Merged
4 of 9 tasks
@climbfuji
climbfuji disabled auto-merge May 27, 2026 15:36
@climbfuji
climbfuji merged commit b379a10 into develop May 27, 2026
6 checks passed
@climbfuji
climbfuji deleted the AlexanderRichert-NOAA-patch-2 branch May 27, 2026 15:37
@github-project-automation github-project-automation Bot moved this from In Progress to Done in spack-stack-2.1.x (2026 Q1) May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

Assignees

@climbfuji climbfuji

Labels

None yet

Projects

No open projects
spack-stack-2.1.x (2026 Q1)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[INSTALL]: gsi-ncdiag tag v1.1.3

2 participants

@AlexanderRichert-NOAA @climbfuji