Skip to content

Fix Apple PowerPC build - #276

Merged
ViralBShah merged 1 commit into
JuliaMath:masterfrom
MarcusCalhoun-Lopez:openlibm_ppc
Jun 25, 2023
Merged

ViralBShah merged 1 commit into
JuliaMath:masterfrom
MarcusCalhoun-Lopez:openlibm_ppc

Conversation

@MarcusCalhoun-Lopez

Copy link
Copy Markdown
Contributor

Apple versions of GCC define ppc instead of powerpc

Fixes #275

Apple versions of GCC define __ppc__ instead of __powerpc__

Fixes JuliaMath#275
@ViralBShah
ViralBShah merged commit 12f5ffc into JuliaMath:master Jun 25, 2023
@barracuda156

Copy link
Copy Markdown
Contributor

@MarcusCalhoun-Lopez @ViralBShah I apologize, I missed this somehow. We also need __ppc64__ there, I believe, or otherwise __POWERPC__ includes both for Apple (and, well, also includes BeOS).

@ViralBShah

Copy link
Copy Markdown
Member

Submit another PR?

@barracuda156

Copy link
Copy Markdown
Contributor

Submit another PR?

@ViralBShah Well, #303 (I know, yeah)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails on macOS with GCC: s_fpclassify.c: error: storage size of 'u' isn't known

3 participants