Skip to content

Correct long double check in CMakeLists.txt and remove duplicate definitions for static library builds too - #293

Merged
ViralBShah merged 2 commits into
JuliaMath:masterfrom
ryonaldteofilo:master
Jan 16, 2024
Merged

ViralBShah merged 2 commits into
JuliaMath:masterfrom
ryonaldteofilo:master

Conversation

@ryonaldteofilo

Copy link
Copy Markdown
Contributor
  • Fixed cmake aarch64 build for macOS due to a mistake in long double == double size check, this should fix CMake build fails on macOS arm64/aarch64 #292 .
  • Apply the filtering out of C implementation if native implementation exists for static library builds as well.
  • Default to building a shared library just like the GNU make build, and updated the README to reflect this.

@ryonaldteofilo

Copy link
Copy Markdown
Contributor Author

Probably should mention that I've confirmed that this indeed does fix #292 :)

@ViralBShah
ViralBShah merged commit f3eec73 into JuliaMath:master Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CMake build fails on macOS arm64/aarch64

2 participants