Repository navigation
CMake Changes - #299
Merged
Merged
CMake Changes#299
Conversation
Member
|
Merge? |
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 38.24% 39.02% +0.78%
==========================================
Files 233 233
Lines 6139 6144 +5
Branches 1607 1607
==========================================
+ Hits 2348 2398 +50
+ Misses 3394 3393 -1
+ Partials 397 353 -44 ☔ View full report in Codecov by Sentry. |
Member
|
Can you rebase to master? Is this ok to merge given the changes in #302? It looks like there is no conflict. |
Collaborator
|
Hello @theoparis , could you confirm that the current git version works for you with FetchContent? Also, if you don't mind me asking, have you tried using package managers instead of FetchContent? I'm assuming you're using it to pull OpenLibm into your project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.