Repository navigation
Fix risc-v build - #305
Merged
Merged
Fix risc-v build#305
Conversation
Two fixes in one: Firstly, replace non-standard __uint64_t with standard (but optional) uint64_t. __uint64_t is not a part of C standard; it is defined by some platforms but might not be present in every environment (e.g. in freestanding build). On the other hand, uint64_t is standard C. It is optional but virtual guaranteed to be present for any 32/64 bit machine. Secondly, mark riscv64 for 128-bit long double in make/cmake files. This fixes cmake build (which detects presence of long double and tries to compile extended functions), and brings make build to do the same.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 39.02% 39.02%
=======================================
Files 233 233
Lines 6144 6144
Branches 1608 1607 -1
=======================================
Hits 2398 2398
Misses 3393 3393
Partials 353 353 ☔ View full report in Codecov by Sentry. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes in one:
Firstly, replace non-standard __uint64_t with standard (but optional) uint64_t. __uint64_t is not a part of C standard; it is defined by some platforms but might not be present in every environment (e.g. in freestanding build). On the other hand, uint64_t is standard C. It is optional but virtually guaranteed to be present for any 32/64 bit machine.
Secondly, mark riscv64 for 128-bit long double in make/cmake files. This fixes cmake build (which detects presence of long double and tries to compile extended functions), and brings make build to do the same.