Repository navigation
BLD: bump OpenBLAS for SkylakeX - #3
Merged
Merged
Conversation
* bump version of OpenBLAS used to most recent commit on 0.3.7.dev branch, as it will contain more fixes related to SkylakeX kernel affecting NumPy linalg tests
Collaborator
|
Looks good. Do you want to merge this? |
Collaborator
Author
|
I’m away from computer for a few hours; feel free to merge if green
…On Mon, May 6, 2019 at 12:25 Charles Harris ***@***.***> wrote:
Looks good. Do you want to merge this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB4JOZWKXTH6QYUA5ZHVECLPUCAZVANCNFSM4HLBRFAA>
.
|
Collaborator
|
Thanks Tyler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recent commit on 0.3.7.dev branch, as it
will contain more fixes related to SkylakeX
kernel affecting NumPy linalg tests
In particular, we have an interest in OpenMathLib/OpenBLAS#2111
which specifically mentions the NumPy problem & was merged even more recently.
If this builds successfully, I'll want to try bumping OpenBLAS again in numpy/numpy#13466
which contains Intel SDE emulation for SkylakeX issue with NumPy, to check for resolution.
Obviously, we'd like to automate this process a little more re: cross-project testing, but for now at least we have some reproducers / a CI model to verify.