Skip to content

Update version to v0.3.11, Fix INTERFACE64, gcc version - #43

Merged
mattip merged 6 commits into
MacPython:masterfrom
mattip:win-fixes
Oct 21, 2020
Merged

mattip merged 6 commits into
MacPython:masterfrom
mattip:win-fixes

Conversation

@mattip

@mattip mattip commented Oct 16, 2020

Copy link
Copy Markdown
Collaborator

Fixes gh-42. There must be a better way to get the matrix values into the environment, but this should work.

@mattip

mattip commented Oct 16, 2020

Copy link
Copy Markdown
Collaborator Author

Merging this will change the hashes for the already-uploaded packages. Should I go ahead and get the HEAD from OpenBLAS so we can check their fix for numpy/numpy#16774 ?

@mattip

mattip commented Oct 16, 2020

Copy link
Copy Markdown
Collaborator Author

... and of course I have a typo.

@mattip mattip changed the title Fix INTERFACE64, gcc version Update version to v0.3.11, Fix INTERFACE64, gcc version Oct 17, 2020
@mattip

mattip commented Oct 18, 2020

Copy link
Copy Markdown
Collaborator Author

gcc fails to compile 0.3.11 since the mingw version is 8.1.0 which suffers from this bug:

config/i386/avx512fintrin.h (_mm512_abs_pd, _mm512_mask_abs_pd): Use
__m512d type for __A argument rather than __m512

It doesn't appear that there are later versions of mingw available.

@mattip
mattip force-pushed the win-fixes branch 2 times, most recently from 6949756 to 6eea4cb Compare October 18, 2020 06:52
@mattip

mattip commented Oct 18, 2020

Copy link
Copy Markdown
Collaborator Author

[skip travis]

@mattip

mattip commented Oct 18, 2020

Copy link
Copy Markdown
Collaborator Author

Now getting

undefined reference to `dgetri_`

in 32-bit tests. When do we drop windows 32-bits?

@mattip
mattip force-pushed the win-fixes branch 2 times, most recently from 01fcedd to 6a117a4 Compare October 18, 2020 12:40
@tylerjereddy

Copy link
Copy Markdown
Collaborator

When do we drop windows 32-bits?

My impression was that Python 32-bit interpreter installs on Windows were still very common for whatever reason. I think Matthew Brett may have been saying that?

@charris

charris commented Oct 18, 2020

Copy link
Copy Markdown
Collaborator

I think Matthew Brett may have been saying that?

That's also my recollection.

@mattip

mattip commented Oct 19, 2020

Copy link
Copy Markdown
Collaborator Author

I was blaming the 32-bit build too soon. I set fail-fast to false so all builds run to completion, and they all give the undefined reference to dgetri_ error. I am trying to reproduce locally.

@matthew-brett

Copy link
Copy Markdown
Contributor

About importance of Windows 32-bit bit - yes, that is usually me quoting Steve Dower : pypa/manylinux#118 (comment) . I haven't investigated the wheel download statistics though.

@mattip

mattip commented Oct 19, 2020

Copy link
Copy Markdown
Collaborator Author

something is still off with the interface64 builds, the internal OpenBLAS linktest is failing.

@mattip

mattip commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator Author

self-merging to move this chain of fixes forward

@mattip
mattip merged commit 3c79d00 into MacPython:master Oct 21, 2020
@mattip
mattip deleted the win-fixes branch December 22, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows uploads are not picking up the 64-bit interface difference

4 participants