Skip to content

Delete session asynchronously - #1117

Merged
malatewang merged 2 commits into
mainfrom
async_delete
May 1, 2026
Merged

malatewang merged 2 commits into
mainfrom
async_delete

Conversation

@malatewang

Copy link
Copy Markdown
Contributor

Purpose of the change

Improve user experience when deleting a session.

Description

When deleting a session, MemMachine will delete all the data from DB, which may take a long time if there are large number of memory entries. This can cause bad user experience or front-end timeout. In this PR, the session deletion is performed asynchronously. When the user requests delete, the session status is updated, and a background job does the actual deletion job. The side effect is that the same session ID can not be used before the actual background job is completed.

Fixes/Closes

Fixes #(issue number)

Type of change

[Please delete options that are not relevant.]

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

[Please delete options that are not relevant.]

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Test Results: [Attach logs, screenshots, or relevant output]

Checklist

[Please delete options that are not relevant.]

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

Screenshots/Gifs

[If applicable, add screenshots or GIFs that show the changes in action. This is especially helpful for API responses. Otherwise, delete this section or type "N/A".]

Further comments

[Add any other relevant information here, such as potential side effects, future considerations, or any specific questions for the reviewer. Otherwise, type "None".]

@malatewang
malatewang force-pushed the async_delete branch 8 times, most recently from 73590fb to 3cf3680 Compare February 18, 2026 21:26
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If you are still working on this, please push a commit or leave a comment. Reviewers: please respond, or add the keep-open label if this PR should be held open for a longer review cycle.

@github-actions github-actions Bot added the Stale label Apr 25, 2026
@malatewang
malatewang force-pushed the async_delete branch 2 times, most recently from 285ef77 to eb45064 Compare April 30, 2026 22:45
@github-actions github-actions Bot removed the Stale label May 1, 2026
@malatewang
malatewang merged commit 1e21938 into main May 1, 2026
52 checks passed
@malatewang
malatewang deleted the async_delete branch May 1, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants