Repository navigation
Conversation
edwinyyyu
force-pushed
the
segment_store
branch
11 times, most recently
from
March 9, 2026 22:27
c292ae4 to
9652499
Compare
26 tasks
edwinyyyu
force-pushed
the
segment_store
branch
from
March 11, 2026 22:25
8e44849 to
677b183
Compare
edwinyyyu
marked this pull request as ready for review
March 11, 2026 22:36
edwinyyyu
marked this pull request as draft
March 12, 2026 20:14
edwinyyyu
force-pushed
the
segment_store
branch
2 times, most recently
from
March 13, 2026 17:32
cd47f64 to
5d83470
Compare
edwinyyyu
force-pushed
the
segment_store
branch
2 times, most recently
from
March 13, 2026 20:19
07ba8e8 to
6feb24b
Compare
malatewang
reviewed
Mar 13, 2026
malatewang
left a comment
Contributor
There was a problem hiding this comment.
Let put vector store to a separate PR
edwinyyyu
force-pushed
the
segment_store
branch
5 times, most recently
from
March 18, 2026 03:26
9d4987e to
21fc072
Compare
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: Edwin Yu <[email protected]>
Contributor
Author
|
Review effort moved to #1205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Motivation:
Description
Based on #1375.
#1205 based on this.
Changes:
each segment comes from exactly one episode
each derivative comes from exactly one segment
alternative considered: many-to-many segments-to-derivatives
Approach to deletion:
Scoping:
by partition key: should allow sharding and horizontal scaling
this memory will be parallel to
DeclarativeMemoryDecisions to make:
POC:
Type of change
Will eventually be breaking or require new API.
How Has This Been Tested?
APIs and data models not tested.
Checklist
Maintainer Checklist