Repository navigation
Fix deadlock due to non-reentrant lock pool - #1312
Merged
Merged
Conversation
Signed-off-by: Edwin Yu <[email protected]>
edwinyyyu
force-pushed
the
fix_rwlock_deadlock
branch
from
April 8, 2026 18:26
9d46337 to
711e857
Compare
jealous
approved these changes
Apr 8, 2026
8 tasks done
malatewang
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Non-reentrant lock pool will deadlock due to hash collisions.
Hash collisions occur with 100% guarantee as soon as number of keys exceeds the pool size (by default a tiny 128) by pigeonhole principle.
Even worse, it takes only 14 keys for collision probability to be greater than 50%. See https://en.wikipedia.org/wiki/Birthday_problem
Description
Remove non-reentrant lock pool. Dict of locks is small for even tens of thousands of locks.
Fixes/Closes
Fixes #1303
Type of change
[Please delete options that are not relevant.]
How Has This Been Tested?
Checklist
Maintainer Checklist