Repository navigation
Support new vector DB implementation in semantic memory - #1406
Merged
Merged
Conversation
malatewang
force-pushed
the
semantic_vector_db
branch
from
May 15, 2026 23:50
8e5f4d0 to
7031681
Compare
sscargal
requested changes
May 16, 2026
sscargal
left a comment
sscargal
left a comment
Contributor
There was a problem hiding this comment.
Other than the Nebula config example changes that should either be reverted to updated for the Nebula Enterprise database, the remaining changes look good to me.
| # VectorStore for vector-backed semantic memory. | ||
| # Wire it via `semantic_memory.vector_collection`. | ||
| semantic_vector_store: | ||
| provider: qdrant |
Contributor
There was a problem hiding this comment.
We should not use the qdrant database within the Nebular config file; it should be nebula, or left to the Nebula Enterprise team to make the necessary changes..
Contributor
There was a problem hiding this comment.
I was a bit confused by the existence of this file, and this pattern of one config file per storage backend does not seem to scale. Shouldn't we just comment everything out and rely on user/LLM/script to uncomment anything useful?
malatewang
force-pushed
the
semantic_vector_db
branch
from
May 19, 2026 17:24
7031681 to
22aee16
Compare
edwinyyyu
approved these changes
May 19, 2026
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the change
Support vector DB for semantic memory
Description
Current semantic memory supports Neo4j and postgres with vector. This PR adds implementation in semantic memory to support the new vector DB and SQL storage.
Fixes/Closes
Fixes #(issue number)
Type of change
[Please delete options that are not relevant.]
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
[Please delete options that are not relevant.]
Test Results: [Attach logs, screenshots, or relevant output]
Checklist
[Please delete options that are not relevant.]
Maintainer Checklist
Screenshots/Gifs
[If applicable, add screenshots or GIFs that show the changes in action. This is especially helpful for API responses. Otherwise, delete this section or type "N/A".]
Further comments
[Add any other relevant information here, such as potential side effects, future considerations, or any specific questions for the reviewer. Otherwise, type "None".]