Repository navigation
Add QR code sharing for URL profiles - #850
Merged
Merged
Conversation
|
Please add screenshots or screen recordings of the new features to the body of the PR. |
Author
ok, done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Share QR code directly below Duplicate in the profile menu for imported URL profiles. Selecting it displays the original profile URL in a Material dialog that matches the existing UI.
QR codes are generated locally off the UI thread with UTF-8 support. Links exceeding QR capacity show an error message. The new strings cover every existing app locale, and the dialog closes when the activity is destroyed.
Validation:
:app:assembleMetaDebugsuccessfully for all four supported architectures.git diff --checkpassed.Screenshots
Screenshots from the tested arm64 debug build. The QR code contains a local test-profile URL.