Repository navigation
Request to add tintin++ from pkgsrc-wip #110
Description
Activity
@kflu Hello!
Possible minor suggestions:
- please always run
pkglint -Walland review and fix possible warnings: in that caseGITHUB_PROJECTshould be sorted... but... actually...GITHUB_PROJECTcan be completely omitted because it is derived fromPKGBASEthat should be alreadytintin(so, please remove completelyGITHUB_PROJECTnot needed redefinition) - Instead of hardcoding
GITHUB_RELEASEwith the version number please change it toGITHUB_RELEASE= ${PKGVERSION_NOREV}. In this way when updating just the version number inDISTNAMEneeds to be bumped. HAS_CONFIGUREis not needed because there is alreadyGNU_CONFIGURE
Thank you!
- please always run
OK just fixed all the problems as suggested. Please see pkgsrc-wip f4ee8f05ca07be36d7ad34ccc733f5366dd423fd
- added 2 commits that reference this issue
on Sep 25, 2022 - added a commit that references this issue
on Jan 6, 2023 - added a commit that references this issue
on Jan 18, 2023 - added 8 commits that reference this issue
on Jan 25, 2023 163 remaining items
- added 10 commits that reference this issue
on May 15, 2026 - added a commit that references this issue
on May 21, 2026 - added a commit that references this issue
on Jul 14, 2026 - added 2 commits that reference this issue
on Jul 26, 2026 - added a commit that references this issue
on Sep 17, 2026
I added a package tintin++ in pkgsrc-wip. Can you help upstream it to pkgsrc? The pkgsrc-wip commit is 5b961c0c13ec41cd933d0574d6386420ca5e5370.
I tested it on macos: