Skip to content

Annoying pings #172

Description

@MuntasirSZN

Please stop doing @ in commits. It happened in latest bat upgrade to 0.26.1. I got pinged for no reason. Please remove @ pings in commit message

Activity

  1. iamleot commented on Dec 3, 2025

    @iamleot
    Member

    We usually try to adjust the changelog. But I think you should point out regarding that also to actual upstreams writing such changelogs (package systems usually try to incorporate them as-is so that people following updates are informed about changes) and possibly to GitHub.

    cc: @0323pin FYI

  2. 0323pin commented on Dec 3, 2025

    @0323pin
    Member

    Exactly what @iamleot wrote. I've simply copied upstreams changelog. I'm not going to go through the added burden of checking every singel character someone else writes.

  3. MuntasirSZN commented on Dec 3, 2025

    @MuntasirSZN
    Author

    Hmmm what about just using something like a script that removes those @ chars only? That fixes it. Upstream or anyone wont fix, everyone just adds this pings in changelog (though they don't ping people, thats how gh works)

    @0323pin

  4. cyqsimon commented on Dec 3, 2025

    @cyqsimon
  5. 0323pin commented on Dec 3, 2025

    @0323pin
    Member

    Hmmm what about just using something like a script that removes those @ chars only?

    That could be a possibility, I would still need to remember to run the script on my local machine before pushing it.

    I wish people could just refer the commit hash in the changelog, that would be enough.

  6. MuntasirSZN commented on Dec 4, 2025

    @MuntasirSZN
    Author

    Hmmm what about just using something like a script that removes those @ chars only?

    That could be a possibility, I would still need to remember to run the script on my local machine before pushing it.

    I wish people could just refer the commit hash in the changelog, that would be enough.

    Git hooks exist for this reason.

  7. MuntasirSZN commented on Dec 4, 2025

    @MuntasirSZN
    Author

    @0323pin

    #!/bin/sh
    MSG_FILE="$1"
    
    sed -E -i 's/@([A-Za-z0-9_-]+)/@ \1/g' "$MSG_FILE"

    Changes @xyz to @ xyz. Place this in .git/hooks/commit-msg (use chmod +x to make it executable). Important, this is gnu sed. Change to whatever you want.

  8. 0323pin commented on Dec 4, 2025

    @0323pin
    Member

    Well, I just did sed -i 's,@,,gsimply removing all @.

    Your suggestion on using git hooks will only apply when we change to git or mercury, as currently we are still using cvs and this repository is only a mirror.

    And, before you go there ... no, I don't have access to mirroring process.

  9. MuntasirSZN commented on Dec 4, 2025

    @MuntasirSZN
    Author

    Dead end? Or just dont even add changelog to commit message at all.

    I don't have anything else in mind. But, I want this to stop. Just contributing to xyz means ping in countless repos.

  10. 0323pin commented on Dec 4, 2025

    @0323pin
    Member

    Dead end?

    No but, added burden. I can run sed -i 's,@,,g COMMIT_MSG but, I can't promise I will remember every single time.

    Or just dont even add changelog to commit message at all.

    Kind of agree with you here. Rules say they should be included, so that would be an internal discussion on pkgsrc.

    I want this to stop. Just contributing to xyz means ping in countless repos.

    I got that. I don't know if there are different ways of doing this, though.
    For example, I got @ for the release of 0.11.5 here and got no pings from it.

  11. jperkin commented on Dec 4, 2025

    @jperkin
    Collaborator

    But, I want this to stop.

    We all do, but this is fundamentally a GitHub bug that we have complained about for over a decade now, and they refuse to fix it. Put pressure on them, or vote with your choice of git hosting service. The pkgsrc repository has nothing to do with GitHub, and it's utterly ridiculous to expect us to have to change our procedures to appease them.

  12. MuntasirSZN commented on Dec 4, 2025

    @MuntasirSZN
    Author

    So effectively this is not a dead end @jperkin. Github listened after decades

    https://github.com/orgs/community/discussions/178738

  13. jperkin commented on Dec 4, 2025

    @jperkin
    Collaborator

    Woah, nice! Only a few more days to wait. I'll close this one out now.

  14. added a commit that references this issue on Dec 4, 2025
  15. 45 remaining items

  16. added a commit that references this issue on Jul 30, 2026
  17. added a commit that references this issue on Aug 25, 2026
  18. added a commit that references this issue on Sep 6, 2026
  19. added a commit that references this issue on Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions