Repository navigation
macOS: Some environment variables are not working for alternatives #66
Description
Activity
I think I've seen this worked around by using a shell from pkgsrc, we may want to investigate going back to bootstrapping our own and using it for everything.
For my own project I would like to change the default shebang for wrappers.
It seems that it could be modified in:
https://github.com/NetBSD/pkgsrc/blob/trunk/pkgtools/pkg_alternatives/files/wrapper.sh#L1Do you know by which option the
__SH__or@SH@could be set?- I think it is set to the value of the SHELL environment variable during bootstrap? Bartosz <[email protected]> schrieb am Fr., 12. Juni 2020, 16:13:…For my own project I would like to change the default shebang for wrappers. It seems that it could be modified in: https://github.com/NetBSD/pkgsrc/blob/trunk/pkgtools/pkg_alternatives/files/wrapper.sh#L1 Do you know by which option the __SH__ or @sh@ could be set? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGTQGVY6SWRFL4KFGVY6R3RWIZYVANCNFSM4N4F3IVA> .
Simplest way is:
$ cd pkgsrc/pkgtools/pkg_alternatives $ bmake TOOLS_PLATFORM.sh=/opt/pkg/bin/bash installor whatever shell you want to use outside of
/bin.@jperkin I have found also
WRAPPER_SHvariable in settings:
https://github.com/NetBSD/pkgsrc/blob/pkgsrc-2019Q1/mk/wrapper/wrapper-defs.mk#L41No, that's something completely different (and something you're unlikely to be using).
What do you think about idea, of use bash from
pkgsrc/shells/bashpackage bypkg_alternativesfor wrappers?It will resolve such kind of issues, but it will be additional dependency to
shells/bash.As a local change it would be fine, nothing depends on
pkg_alternativesso you aren't running any risks during upgrades etc.For a wider pkgsrc fix we'll need to look into what the current status of
shells/pdkshis on Darwin by running some bulk builds, and then if it looks ok consider switching bootstrap over to using it by default.After set
TOOLS_PLATFORM.sh=/usr/local/pkg/bin/bash, the wrappers have changed shebang correctly.I will try to overwrite
TOOLS_PLATFORM.shvariable inpkg_alternatives/Makefileand add dependency, to use the defaultshells/bashshell.I have build the
shells/pdkshwithout problems.Logs from shells/pdksh build on macOS Catalina 10.15.5
Click to expand!
pdksh build logs
$ sudo /usr/local/pkg/bin/bmake deinstall ===> Deinstalling for pdksh-5.2.14nb7 Running /usr/local/pkg/sbin/pkg_delete -K /usr/local/pkg/pkgdb pdksh-5.2.14nb7 $ sudo /usr/local/pkg/bin/bmake clean ===> Cleaning for pdksh-5.2.14nb7 $ sudo /usr/local/pkg/bin/bmake install ===> Installing dependencies for pdksh-5.2.14nb7 => Build dependency cwrappers>=20150314: found cwrappers-20180325 ===> Overriding tools for pdksh-5.2.14nb7 ===> Extracting for pdksh-5.2.14nb7 /bin/cp -R /Users/NavKit/dev/pkgsrc/shells/pdksh/files /private/var/tmp/pkgsrc-obj/shells/pdksh/work/pdksh-5.2.14 ===> Patching for pdksh-5.2.14nb7 ===> Creating toolchain wrappers for pdksh-5.2.14nb7 ===> Configuring for pdksh-5.2.14nb7 => Modifying GNU configure scripts to avoid --recheck => Replacing config-guess with pkgsrc versions => Replacing config-sub with pkgsrc versions => Replacing install-sh with pkgsrc version creating cache ./config.cache checking for gcc... clang checking whether we are using GNU C... yes checking how to run the C preprocessor... clang -E checking whether clang needs -traditional... no checking if this is a problematic os... checking for minix/config.h... no no checking for dirent.h that defines DIR... yes checking for opendir in -ldir... no checking for opendir in -lndir... no checking for sane unistd.h... yes checking terminal interface... termios checking for stddef.h... yes checking for stdlib.h... yes checking for string.h... yes checking for memory.h... yes checking for fcntl.h... yes checking for limits.h... yes checking for paths.h... yes checking for sys/param.h... yes checking for sys/resource.h... yes checking for values.h... no checking for ulimit.h... yes checking for sys/time.h... yes checking whether time.h and sys/time.h may both be included... yes checking for sys/wait.h that is POSIX.1 compatible... yes checking for off_t in sys/types.h... yes checking for mode_t in sys/types.h... yes checking for pid_t in sys/types.h... yes checking for uid_t in sys/types.h... yes checking return type of signal handlers... void checking size of int... 4 checking size of long... 8 checking for clock_t in any of <sys/types.h>, <sys/times.h> and <sys/time.h>... yes checking for sigset_t in <sys/types.h> and <signal.h>... yes checking for rlim_t in <sys/types.h> and <sys/resource.h>... yes checking for working memmove... yes checking for memset... yes checking for confstr... yes checking for dup2... yes checking for flock... yes checking for getcwd... yes checking for getwd... yes checking for killpg... yes checking for nice... yes checking for setrlimit... yes checking for strerror... yes checking for strcasecmp... yes checking for strstr... yes checking for sysconf... yes checking for tcsetpgrp... yes checking for ulimit... yes checking for waitpid... yes checking for wait3... yes checking for strlcpy... yes checking for strlcat... yes checking for sigsetjmp... yes checking for valloc... yes checking for getpagesize... yes checking for working mmap... yes checking for lstat... yes checking for sys_errlist declaration in errno.h... no checking for sys_errlist in library... yes checking for sys_siglist declaration in signal.h or unistd.h... yes checking for sys_siglist in library... yes checking time() declaration in time.h... yes checking if times() is present/working... yes checking whether stat file-mode macros are broken... no checking for st_rdev in struct stat... yes checking for working const... yes checking if compiler understands void... yes checking if compiler understands volatile... yes checking if compiler understands prototypes... yes checking if C compiler groks __attribute__(( .. ))... yes checking whether #! works in shell scripts... yes checking for a BSD compatible install... /usr/bin/install -c -o root -g wheel checking if dup2() works (ie, resets the close-on-exec flag)... yes checking flavour of signal routines... posix checking flavour of pgrp routines... posix checking if process group synchronization is required... no checking if opendir() fails to open non-directories... yes checking if you have /dev/fd/n... yes updating cache ./config.cache creating ./config.status creating Makefile creating config.h ===> Building for pdksh-5.2.14nb7 --- emacs.out --- --- ksh.1 --- --- stamp-h --- --- emacs.out --- ./emacs-gen.sh ./emacs.c > tmpemacs.out --- ksh.1 --- ./mkman ksh ./ksh.Man > tmpksh.1 --- stamp-h --- CONFIG_FILES="" CONFIG_HEADERS=config.h ./config.status --- emacs.out --- mv tmpemacs.out emacs.out --- ksh.1 --- mv tmpksh.1 ksh.1 --- stamp-h --- creating config.h config.h is unchanged date > stamp-h --- siglist.out --- --- alloc.o --- --- c_ksh.o --- --- c_sh.o --- --- c_test.o --- --- c_ulimit.o --- --- edit.o --- --- emacs.o --- --- siglist.out --- ./siglist.sh "clang -E -P -DHAVE_CONFIG_H -I. -I." < ./siglist.in > tmpsiglist.out --- alloc.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 alloc.c --- c_ksh.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 c_ksh.c --- c_sh.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 c_sh.c --- c_test.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 c_test.c --- c_ulimit.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 c_ulimit.c --- edit.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 edit.c --- emacs.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 emacs.c --- c_ksh.o --- c_ksh.c:571:13: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ c_ksh.c:571:13: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", c_ksh.c:871:17: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ c_ksh.c:871:17: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", c_ksh.c:962:14: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ c_ksh.c:962:14: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", c_ksh.c:986:14: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ c_ksh.c:986:14: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", c_ksh.c:1234:13: warning: format string is not a string literal (potentially insecure) [-Wformat-security] bi_errorf(null); ^~~~ c_ksh.c:1234:13: note: treat the string as an argument to avoid this bi_errorf(null); ^ "%s", c_ksh.c:1255:13: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ c_ksh.c:1255:13: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", --- eval.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 eval.c --- exec.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 exec.c --- siglist.out --- mv tmpsiglist.out siglist.out --- expr.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 expr.c --- eval.o --- eval.c:340:19: warning: implicit conversion from 'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion] *dp++ = '@' + 0x80; ~ ~~~~^~~~~~ --- history.o --- --- exec.o --- exec.c:148:13: warning: format string is not a string literal (potentially insecure) [-Wformat-security] errorf(null); ^~~~ exec.c:148:13: note: treat the string as an argument to avoid this errorf(null); ^ "%s", --- history.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 history.c --- expr.o --- expr.c:190:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] errorf(null); ^~~~ expr.c:190:11: note: treat the string as an argument to avoid this errorf(null); ^ "%s", --- io.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 io.c --- expr.o --- 1 warning generated. --- jobs.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 jobs.c --- lex.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 lex.c --- c_ksh.o --- 6 warnings generated. --- mail.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 mail.c --- jobs.o --- jobs.c:897:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ jobs.c:897:11: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", --- main.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 main.c --- misc.o --- --- lex.o --- lex.c:858:9: warning: format string is not a string literal (potentially insecure) [-Wformat-security] errorf(null); ^~~~ lex.c:858:9: note: treat the string as an argument to avoid this errorf(null); ^ "%s", --- misc.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 misc.c --- main.o --- main.c:562:13: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shellf(newline); ^~~~~~~ main.c:562:13: note: treat the string as an argument to avoid this shellf(newline); ^ "%s", main.c:861:9: warning: format string is not a string literal (potentially insecure) [-Wformat-security] errorf(null); /* this is never executed - keeps gcc quiet */ ^~~~ main.c:861:9: note: treat the string as an argument to avoid this errorf(null); /* this is never executed - keeps gcc quiet */ ^ "%s", --- exec.o --- 1 warning generated. --- missing.o --- --- path.o --- --- missing.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 missing.c --- path.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 path.c --- misc.o --- misc.c:262:12: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf(newline); ^~~~~~~ misc.c:262:12: note: treat the string as an argument to avoid this shprintf(newline); ^ "%s", --- eval.o --- 1 warning generated. --- misc.o --- misc.c:1014:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] bi_errorf(null); ^~~~ misc.c:1014:15: note: treat the string as an argument to avoid this bi_errorf(null); ^ "%s", misc.c:1040:15: warning: format string is not a string literal (potentially insecure) [-Wformat-security] bi_errorf(null); ^~~~ misc.c:1040:15: note: treat the string as an argument to avoid this bi_errorf(null); ^ "%s", misc.c:1091:20: warning: adding 'int' to a string does not append to the string [-Wstring-plus-int] shprintf("'\\'" + 1 - inquote); ~~~~~~~^~~ misc.c:1091:20: note: use array indexing to silence this warning shprintf("'\\'" + 1 - inquote); ^ & [ ] misc.c:1091:13: warning: format string is not a string literal (potentially insecure) [-Wformat-security] shprintf("'\\'" + 1 - inquote); ^~~~~~~~~~~~~~~~~~~~ misc.c:1091:13: note: treat the string as an argument to avoid this shprintf("'\\'" + 1 - inquote); ^ "%s", --- shf.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 shf.c --- sigact.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 sigact.c --- main.o --- 2 warnings generated. --- syn.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 syn.c --- table.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 table.c --- tree.o --- --- jobs.o --- 1 warning generated. --- tree.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 tree.c --- tty.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 tty.c --- var.o --- --- version.o --- --- var.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 var.c --- version.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 version.c --- vi.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 vi.c --- misc.o --- 5 warnings generated. --- trap.o --- clang -c -DHAVE_CONFIG_H -I. -I. -O2 trap.c --- var.o --- var.c:373:11: warning: format string is not a string literal (potentially insecure) [-Wformat-security] errorf(null); ^~~~ var.c:373:11: note: treat the string as an argument to avoid this errorf(null); ^ "%s", var.c:727:14: warning: format string is not a string literal (potentially insecure) [-Wformat-security] errorf(null); ^~~~ var.c:727:14: note: treat the string as an argument to avoid this errorf(null); ^ "%s", --- vi.o --- vi.c:1761:6: warning: address of array 'newline' will always evaluate to 'true' [-Wpointer-bool-conversion] if (newline) { ~~ ^~~~~~~ --- lex.o --- 1 warning generated. --- var.o --- 2 warnings generated. --- vi.o --- 1 warning generated. --- ksh --- clang -L/usr/local/pkg/lib -o ksh alloc.o c_ksh.o c_sh.o c_test.o c_ulimit.o edit.o emacs.o eval.o exec.o expr.o history.o io.o jobs.o lex.o mail.o main.o misc.o missing.o path.o shf.o sigact.o syn.o table.o trap.o tree.o tty.o var.o version.o vi.o ===> Installing for pdksh-5.2.14nb7 => Generating pre-install file lists => Creating installation directories /usr/bin/install -c -o root -g wheel -m 755 /private/var/tmp/pkgsrc-obj/shells/pdksh/work/pdksh-5.2.14/ksh /private/var/tmp/pkgsrc-obj/shells/pdksh/work/.destdir/usr/local/pkg/bin/pdksh /usr/bin/install -c -o root -g wheel -m 644 /private/var/tmp/pkgsrc-obj/shells/pdksh/work/pdksh-5.2.14/ksh.1 /private/var/tmp/pkgsrc-obj/shells/pdksh/work/.destdir/usr/local/pkg/man/man1/pdksh.1 => Automatic stripping binaries => Automatic manual page handling => Generating post-install file lists => Checking file-check results for pdksh-5.2.14nb7 => Creating binary package /private/var/tmp/pkgsrc-obj/shells/pdksh/work/.packages/pdksh-5.2.14nb7.tgz ===> Building binary package for pdksh-5.2.14nb7 => Creating binary package /Users/NavKit/dev/pkgsrc/packages/All/pdksh-5.2.14nb7.tgz ===> Installing binary package of pdksh-5.2.14nb7 =========================================================================== The following lines can be added to /etc/shells: /usr/local/pkg/bin/pdksh =========================================================================== $ /usr/local/pkg/bin/pdksh $ exit $ uname -a Darwin pl1mcl-5287921 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64@jperkin Do you know how to setup shell from pkgsrc globally in bootstrap?
The bootstrap tools are defined here:
https://github.com/NetBSD/pkgsrc/blob/trunk/mk/tools/tools.Darwin.mk#L100How these paths needs to be set properly to use pkgsrc shell and how add dependency to boostrap?
Yes, I'm currently testing this in a bulk build.
Could you please share the code with updated bootstrap?
I would like to start my own testing.For testing I'm just using bootstrap with the
--fullargument, this ensures that pdksh is bootstrapped and set as the default shell. If it looks ok then the permanent fix would be addingneed_ksh=trueto the Darwin setup section, probably being limited to OS releases that ship with SIP.@jperkin Do you know if the
zshcould be used by default for macOS/Darwin, as it is default shell:
https://www.theverge.com/2019/6/4/18651872/apple-macos-catalina-zsh-bash-shell-replacement-features
?One of the build hosts crashed over the weekend (Catalina is highly unreliable), I'll need to restart it.
As for zsh, I wouldn't recommend it, it's not designed to be a fast POSIX-only shell, but more as a feature-full interactive shell.
245 remaining items
- added 3 commits that reference this issue
on May 21, 2026 - added a commit that references this issue
on Jun 8, 2026 - added a commit that references this issue
on Jul 13, 2026 - added a commit that references this issue
on Aug 26, 2026 - added 2 commits that reference this issue
on Sep 6, 2026 - added 2 commits that reference this issue
on Sep 24, 2026
Metadata
Metadata
Assignees
Labels
No labels
Due to System Integrity Protection (SIP) on macOS systems, the binaries from the
/bin(eg./bin/bash) are not allowed to handle this environment variables. More information: https://support.apple.com/en-us/HT204899Example of SIP:
./test.shfileDYLD_LIBRARY_PATH=/lalala ./test.shResult:
$ DYLD_LIBRARY_PATH=/lalala ./test.shThe current generated alternative script files on macOS from the
pkg_alternatives packageare having as interpreter/bin/bash, eg.pip3:This is a bit problematic in case of macOS as due to SIP protection for example declared environment variable like
DYLD_LIBRARY_PATHis rejected.This will lead eventually to problems for trying to do things like
DYLD_LIBRARY_PATH=/path_with_dylibs /usr/local/pkg//bin/ctestwhich is pretty common.