Skip to content

lore's --registry flag is read by nothing #1012

Open

Description

@David-Noble-at-work

lore declares --registry on its root ("Registry path", cmd/lore/lore/root.go:54), and nothing reads it: no code asks for the flag, and BindFlags binds it to lore.registry, which nothing reads either. The registry lore uses comes from the typed configuration: registry.url and registry.branch (cmd/internal/config/registry.go:14), overridden by DEVLORE_REGISTRY_URL and DEVLORE_REGISTRY_BRANCH (cmd/internal/config/config.go:147-150), with RegistryConfig.WithDefaults filling what is unset (cmd/internal/lorepackage/registry.go:35-40). Its local clone lives at devlore.CachePath("registry").

The owner, 2026-10-02: "that setting ought to override the values we hold in configuration or the environment."

Found 2026-10-02 at 01634491, checking that every program holds its own defaults (#1009). The same defect as writ's --target, which lane 7 of #916 (#926) removes.

Resolution

--registry overrides the registry setting it names over the environment and the file, as #1010 does for the model flags. Which setting it names, the repository URL or a local path in place of the clone, is settled in this lane's plan, and the help text says it.

Plan and design documents

Kind Document
Plan No plan yet
Design docs/architecture/configuration.md

Epic: #441 · Feature: #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions