Skip to content

devlore-test run litters the working directory with per-fixture artifacts #665

Open

Description

@David-Noble-at-work

devlore-test run <fixture> writes its outputs into the current working directory, not beside the fixture or into a temp directory:

[devlore-test] [+] summary=test_service.summary.json graph=test_service.graph.yaml receipt=test_service.receipt.yaml

Run the suite by hand from the repository root and it litters the root with three files per fixture — 73 untracked files in one sweep here. .gitignore covers none of them, so they all show up as untracked and are easy to sweep into a commit with git add -A.

The Go harness never shows this: it runs in a temp directory.

Options

  1. Default the outputs next to the fixture being run.
  2. Default them to a temp directory, with a flag to keep them.
  3. Leave the behavior and add *.graph.yaml, *.receipt.yaml, *.summary.json to .gitignore.

3 is the cheap half and worth doing regardless — but it hides the mess rather than removing it, and those extensions are generic enough that ignoring them repository-wide could mask a real file someone means to track.

Found while running the fixture suite by hand for #663.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Epic:QualityCoverageCode quality, coverage, and the lint gatesbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions