You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Finding, 2026-09-09, from the #814 review: buildPackage in cmd/lore/lore/builder.go walks PhaseOrder(lorepackage.Deploy) unconditionally. The upgrade, decommission and reconcile orders are
declared in lorepackage/lifecycle.go and no planner path builds them; addNativeSoftwarePackages maps PMRemove and PMUpgrade to pkg.remove and pkg.upgrade, and nothing reaches those cases. When this
feature's plan opens, buildPackage takes the action as a parameter and the three orders become reachable.
Activity
David-Noble-at-work commentedon Sep 10, 2026
Finding, 2026-09-09, from the #814 review:
buildPackageincmd/lore/lore/builder.gowalksPhaseOrder(lorepackage.Deploy)unconditionally. The upgrade, decommission and reconcile orders aredeclared in
lorepackage/lifecycle.goand no planner path builds them;addNativeSoftwarePackagesmapsPMRemoveandPMUpgradetopkg.removeandpkg.upgrade, and nothing reaches those cases. When thisfeature's plan opens,
buildPackagetakes the action as a parameter and the three orders become reachable.