You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
writ upgrade and reconcile do not see the segments deploy was given: -s is deploy-only, and reconcile's Config.Segments is never read #970
writ deploy -s KEY=value sets or appends a segment (cmd/writ/writ/config.go:94-101, segment.go:125-137), but only deploy registers the flag (cmd/writ/writ/commands.go:58):
writ upgrade re-renders templates from segments (cmd/writ/writ/upgrade/upgrade.go:100), reading WRIT_SEGMENT_* but not -s. A deploy made with -s renders differently on upgrade.
Reconcile's Config.Segments is set (config.go:179, commands.go:271) and never read (cmd/writ/writ/reconcile/reconcile.go:42-43 is its only occurrence), despite the "freshness comparison" comment at config.go:177-178.
WRIT_SEGMENT_<NAME> fills only segments that already exist (detect.go:45-57), so an environment variable can't add a custom segment the way -s can.
The segments a deploy used are the segments its upgrade and reconcile use: recorded, or taken from the same flags and environment, and read by reconcile or removed from its config.
Activity