Repository navigation
feat(op): Add **kwargs support to receiver bridges (#264) - #267
Merged
Merged
Conversation
Phase 1.50: extend both ExecutingReceiver and PlanningReceiver bridges to handle **kwargs. A "**kwargs" entry in Params collects remaining keyword arguments into a map[string]any parameter (executing) or dict sub-slots (planning). - ExecutingReceiver: split incoming kwargs into known/extra, unmarshal extras into map[string]any, use Call (not CallSlice) when **kwargs coexists with *args - PlanningReceiver: split incoming kwargs, fill extras as dict sub-slots via FillSlot - Restore kwargs on plan Provider Degraded/Fatal methods - Restore devlore-test template kwargs scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1.50 of #264 — add
**kwargssupport to both receiver bridges."**kwargs"in Params collects remaining keyword arguments into amap[string]anyGo parameter. When**kwargscoexists with*args, the Go method is non-variadic ([]any+map[string]any), soCallis used instead ofCallSlice.kwargs.path,kwargs.service) viaFillSlot.DegradedandFatalrestored to(format any, args []any, kwargs map[string]any)signature.plan.degraded("wrote {{ .path }}", path=written),plan.fatal("{{ .service }} startup failed", service=svc).Test plan
make test— all 80 packages passmake lint— 198 issues (matches develop baseline)