Repository navigation
fix(build,docs): windows platform splits; provider guide matches astro schema - #291
Merged
David-Noble-at-work merged 1 commit intoJul 25, 2026
Merged
Conversation
…o schema pkg/op: syscall.Umask does not exist in the Windows syscall package, so Release's windows/amd64 cross-build failed at make dist-all. Split the umask read into build-tagged files: processUmask() does the Umask(0) round-trip on unix and returns zero on Windows (no umask; the base mode passes through unmasked). pkg/op/provider/file: *syscall.Stat_t also does not exist on Windows -- masked in CI because nothing depending on pkg/op compiled after pkg/op failed. Split statIdentity() the same way: unix returns Ino/Dev from Stat_t; Windows returns zeros, so statTupleEtag falls back to size+mtime and Observe reports no inode or device. ENOTEMPTY/ENOTDIR stay put -- those Errno constants exist on Windows. default_funcs.go: parameter bullets renamed env: -> runtimeEnvironment:. docs/guides/provider-development.md: category "development" is not in the site's Astro guides enum (overview|tutorial|concept|reference), which broke the website deploy after the docs sync merged. Now category "tutorial", retitled "How to create and modify providers". All 12 other guides carry valid categories. Verified: gofmt clean; make vet; make test; make dist-all compiles all six platforms including windows/amd64 and windows/arm64. Plan and chartered follow-ups: docs/plans/fix-windows-build-and-guide-category.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two failures left by #290's merge. (1) Release:
syscall.Umaskand*syscall.Stat_tdo not exist on Windows; both uses now sit behind//go:build unix/windowssplits (processUmask()in pkg/op,statIdentity()in the file provider), andmake dist-allcompiles all six platforms. The Stat_t break was masked in CI because pkg/op failed first. (2) Website deploy:provider-development.mdcarriedcategory: "development", rejected by the site's Astro guides schema; now"tutorial", retitled "How to create and modify providers". After merge the pipeline self-heals: Release re-runs and creates the skipped install-script sync PR, and docs-publish syncs the corrected guide so the site deploy goes green. Chartered follow-ups in docs/plans/fix-windows-build-and-guide-category.md.