Repository navigation
build(dist): keep non-release tags out of the default version - #294
Merged
Merged
Conversation
DEVLORE_VERSION defaulted to plain git describe --tags, which can resolve to non-release tags such as develop/lkg-11; the slash-bearing version breaks the dist archive path and forced a manual override for any local make dist-all. Add --match "v*" so describe only resolves release-style tags; --always still falls back to a bare commit hash when no such tag is reachable. CI is unaffected: the Release workflow determines and passes its version explicitly. Verified: make -n dist-all derives a slash-free v0.1.0-dev.* version; make dist-all with no override completes all six platforms. Chartered follow-up 3 of docs/plans/fix-windows-build-and-guide-category.md; plan: docs/plans/dist-version-sanitize.md.
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chartered follow-up 3 of
docs/plans/fix-windows-build-and-guide-category.md. Plaingit describe --tagscan resolve to non-release tags likedevelop/lkg-11, and the slash-bearing version breaks the dist archive path, forcing a manualDEVLORE_VERSIONoverride for localmake dist-all.--match "v*"restricts describe to release-style tags, with--alwaysstill falling back to a bare commit hash. CI is unaffected — Release passes its version explicitly. Verified: no-overridemake dist-allcompletes all six platforms with correctly named archives.