Skip to content

test(lore): restore the characterization tests lost from PR #371 - #372

Merged
David-Noble-at-work merged 1 commit into
developfrom
test/lore-onboard-characterization
Aug 12, 2026
Merged

David-Noble-at-work merged 1 commit into
developfrom
test/lore-onboard-characterization

Conversation

@David-Noble-at-work

Copy link
Copy Markdown
Contributor

Restores the characterization tests that were lost when #371 merged.

What happened

#371's recorded head was d75cb867, its first commit. The test commit f06cbc9c was pushed to the branch, but GitHub's pull request head never advanced, so the squash merge took the decomposition without its tests.

f06cbc9c carries zero check runs — CI never executed these tests. The five green checks reported on #371 all belong to d75cb867. Nothing was lost: f06cbc9c remained intact on GitHub and these three files are restored from it verbatim, not rewritten.

Develop currently holds the runOnboard and generateManifest decomposition with no test covering either function. This PR closes that gap, and is the first CI execution of these tests — they assert exact byte sequences including newlines, which so far has only been exercised on macOS.

The tests

Unchanged from the reviewed commit. Expectations were hand-derived from the pre-decomposition implementations rather than captured from the refactored code, and both suites were mutation-checked:

Mutation Failed exactly
annotation indent " # " → " # " the two annotation-indent subtests
output-dir default "." → "./" TestParseLoreOnboardConfig_DefaultsOutputDirToWorkingDirectory

Coverage restored

Package Before After
cmd/lore/lore/onboard 0% 25.8%
cmd/lore/lore 12% 19.8%

Per-helper blocks: parseLoreOnboardConfig 3/3, newOnboardProvider 5/5, reportOnboardResult 13/13, writeOnboardManifest 3/3. syncedRegistry (0/6) and runOnboard itself (0/7) remain uncovered — both are bound to the registry and the network.

Verified locally: make test green (zero FAIL/panic by count), gofmt clean.

PR #371 merged at d75cb86, its first commit. The test commit f06cbc9 was
pushed to the branch but GitHub's record of the pull request head never
advanced past d75cb86, so the squash merge took the decomposition without its
tests. f06cbc9 carries zero check runs — CI never executed these tests, and
the five green checks reported on #371 all belong to the pre-test commit.

Nothing was lost: f06cbc9 remained intact on GitHub and these three files are
restored from it verbatim, byte for byte, rather than rewritten.

That leaves develop currently holding the runOnboard and generateManifest
decomposition with no test covering either. This commit closes that gap. It is
also the first time these tests run on Linux and Windows; they assert exact
byte sequences including newlines, which has only been exercised on macOS.

The tests themselves are unchanged from the reviewed commit. Expectations were
hand-derived from the pre-decomposition implementations rather than captured
from the refactored code, and both suites were mutation-checked: a one-space
change to the annotation indent and a "." -> "./" change to the output
directory default each failed exactly the tests that should have failed.

Coverage restored: cmd/lore/lore/onboard 0% -> 25.8%, cmd/lore/lore 12% ->
19.8%. Per-helper blocks: parseLoreOnboardConfig 3/3, newOnboardProvider 5/5,
reportOnboardResult 13/13, writeOnboardManifest 3/3. syncedRegistry (0/6) and
runOnboard itself (0/7) stay uncovered — both are bound to the registry and the
network.

Verified: make test green, zero FAIL or panic lines by count; gofmt clean.
Plan: docs/plans/audit-remediation.md (phase 1b-i).
Issue: #365
@David-Noble-at-work David-Noble-at-work self-assigned this Aug 12, 2026
@David-Noble-at-work
David-Noble-at-work merged commit 360a7a8 into develop Aug 12, 2026
5 checks passed
@David-Noble-at-work
David-Noble-at-work deleted the test/lore-onboard-characterization branch August 12, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant