Repository navigation
docs: the canonical-Rel plan and the corrected Windows baseline - #391
Merged
Merged
Conversation
Two plan documents, landing after the work they describe. docs/plans/fsroot-canonical-rel.md is issue #377's plan: rel canonical slash form at every construction and decode site, abs OS-native, every non-test Rel() consumer audited (two of them — walkDir and merkleRoot — were handing native-form rel to io/fs APIs whose contract requires slash paths, so the fix repaired them rather than risking them). Both rulings are recorded: existing serialized documents are greenfield, and Abs()-class test expectations are platform-correct rather than slash literals. Its Outcome section records what actually happened: the implementation landed inside PR #389 (the Apache-2.0 relicense) rather than as its own PR — it was in-flight in the same working tree when the licensing sweep staged whole directories, and the ruling was to merge with the entanglement disclosed in the PR body rather than split commits or rewrite a shared branch. Issue #377 closed by that merge. Measured on #389's own windows test leg: 85 -> 57 failures, every fsroot/triad path assertion and TestRegistry_FilePaths cleared, zero build failures. The attribution correction is recorded too: the earlier ~50-of-85 estimate was wrong (the separator-direct share was 28), and the surviving receipt/graph-resume round-trips have a second cause beyond separator form — the first thing to read in the remaining-57 triage. docs/plans/platform-test-matrix.md gains the corrected phase-2 baseline: with the three formerly-[build failed] packages compiling on Windows (PR #388), the honest count was 85, not 34 — the FAIL-line counting had silently excluded three entire suites. Documentation only; no code changes. Issues: #377 (closed), #373
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two plan documents, landing after the work they describe.
docs/plans/fsroot-canonical-rel.md— issue #377's plan, with its Outcome recorded honestly: the implementation landed inside PR #389 (the relicense) by explicit ruling after a working-tree entanglement, with the disclosure and measurement in that PR's body. Measured effect on #389's own windows leg: 85 → 57; everyfsroot/triadpath assertion andTestRegistry_FilePathscleared. The attribution correction is on the record — the separator-direct share was 28, not ~50, and the surviving receipt/graph-resume round-trips have a second cause that heads the remaining-57 triage.docs/plans/platform-test-matrix.md— gains the corrected phase-2 baseline (85, not 34, once the three[build failed]packages compiled).Documentation only; no code changes.