Repository navigation
The last artifacts carrying retired placement vocabulary - #729
Merged
Merged
Conversation
Closes #725. #715 renamed the types, constants, accessors, directives, and test functions. Two artifacts still spelled the retired word. pkg/op/provider/ui/root_test.go -> promotion_test.go Its tests became TestUIPromoted_* and the filename did not follow. Named for the OUTCOME rather than the axis: both tests are about a promoted provider, and a qualified provider's tests would sensibly live elsewhere. git mv, so history follows. tierCollisionRootProvider -> tierCollisionPromotedProvider collisionRootReceiverType -> collisionPromotedReceiverType A synthetic fixture declaring PlacementPromoted, described as a "root provider". What was deliberately NOT renamed, and why it matters These contain "root" in a FILESYSTEM sense, and a word-level sweep would break their meaning without breaking the build -- which is the failure mode #716's name-mapping appendix exists to prevent, applied here: pkg/fsroot/** 51 occurrences plan/root_binding_test.go the RUN root TestRun_BindsPendingResourcesToTheRunRoot TestGlob_RefusesPatternsOutsideTheRoot the scoped root TestNewRuntimeEnvironment_MintsRootFromAnchor TestLintCommands_LoadConfigFromGitRoot the git root Verified untouched by their absence from this diff, which is the only way a table of changes can distinguish "correctly unchanged" from "missed". One correction to the issue's acceptance It asks that "the two historical notes survive". Only one still NAMES the retired identifiers -- receiver_type.go, explaining why ProviderRole, RoleAction, and Dispatch() went stale. The receiver_registry.go note survives as a note but was rewritten in current vocabulary during #715, so it records the doc correction without naming dead symbols. Better, but the acceptance implied two and there is one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #725. Two files, nine lines each way.
#715 renamed the types, constants, accessors, directives, and test functions. Two artifacts still spelled the
retired word.
pkg/op/provider/ui/root_test.gopromotion_test.gotierCollisionRootProvidertierCollisionPromotedProvidercollisionRootReceiverTypecollisionPromotedReceiverTypeThe file is named for the outcome rather than the axis: both its tests are
TestUIPromoted_*, and aqualified provider's tests would sensibly live elsewhere.
git mv, so history follows — the diff records arename at 100% similarity rather than an add plus a delete.
The reviewable part is what was NOT renamed
These contain "root" in a filesystem sense. A word-level sweep would break their meaning without breaking
the build, which is the failure mode #716's name-mapping appendix exists to prevent — and this is the first
change to apply it.
pkg/fsroot/**plan/root_binding_test.goTestRun_BindsPendingResourcesToTheRunRootTestGlob_RefusesPatternsOutsideTheRootTestNewRuntimeEnvironment_MintsRootFromAnchorTestLintCommands_LoadConfigFromGitRootVerified untouched by their absence from this diff — the only way a table of changes can distinguish
"correctly unchanged" from "missed".
One correction to the issue's acceptance
#725 asks that "the two historical notes survive." Only one still names the retired identifiers:
receiver_type.go, explaining whyProviderRole,RoleAction, andDispatch()went stale. Thereceiver_registry.gonote survives as a note but was rewritten in current vocabulary during #715, so itrecords the doc correction without naming dead symbols. Better than asked for, but the acceptance implied two
and there is one.
Verified
make check,make test-race,make test-scenario— all pass.