Skip to content

The last artifacts carrying retired placement vocabulary - #729

Merged
David-Noble-at-work merged 1 commit into
developfrom
placement-vocabulary
Aug 28, 2026
Merged

David-Noble-at-work merged 1 commit into
developfrom
placement-vocabulary

Conversation

@David-Noble-at-work

Copy link
Copy Markdown
Contributor

Closes #725. Two files, nine lines each way.

#715 renamed the types, constants, accessors, directives, and test functions. Two artifacts still spelled the
retired word.

Before After
pkg/op/provider/ui/root_test.go promotion_test.go
tierCollisionRootProvider tierCollisionPromotedProvider
collisionRootReceiverType collisionPromotedReceiverType

The file is named for the outcome rather than the axis: both its tests are TestUIPromoted_*, and a
qualified provider's tests would sensibly live elsewhere. git mv, so history follows — the diff records a
rename at 100% similarity rather than an add plus a delete.

The reviewable part is what was NOT renamed

These contain "root" in a filesystem sense. A word-level sweep would break their meaning without breaking
the build
, which is the failure mode #716's name-mapping appendix exists to prevent — and this is the first
change to apply it.

pkg/fsroot/** 51 occurrences
plan/root_binding_test.go the RUN root
TestRun_BindsPendingResourcesToTheRunRoot
TestGlob_RefusesPatternsOutsideTheRoot the scoped root
TestNewRuntimeEnvironment_MintsRootFromAnchor
TestLintCommands_LoadConfigFromGitRoot the git root

Verified untouched by their absence from this diff — the only way a table of changes can distinguish
"correctly unchanged" from "missed".

One correction to the issue's acceptance

#725 asks that "the two historical notes survive." Only one still names the retired identifiers:
receiver_type.go, explaining why ProviderRole, RoleAction, and Dispatch() went stale. The
receiver_registry.go note survives as a note but was rewritten in current vocabulary during #715, so it
records the doc correction without naming dead symbols. Better than asked for, but the acceptance implied two
and there is one.

Verified

make check, make test-race, make test-scenario — all pass.

Closes #725.

#715 renamed the types, constants, accessors, directives, and test functions. Two
artifacts still spelled the retired word.

  pkg/op/provider/ui/root_test.go -> promotion_test.go
    Its tests became TestUIPromoted_* and the filename did not follow. Named for the
    OUTCOME rather than the axis: both tests are about a promoted provider, and a
    qualified provider's tests would sensibly live elsewhere. git mv, so history follows.

  tierCollisionRootProvider -> tierCollisionPromotedProvider
  collisionRootReceiverType -> collisionPromotedReceiverType
    A synthetic fixture declaring PlacementPromoted, described as a "root provider".

What was deliberately NOT renamed, and why it matters
  These contain "root" in a FILESYSTEM sense, and a word-level sweep would break their
  meaning without breaking the build -- which is the failure mode #716's name-mapping
  appendix exists to prevent, applied here:

    pkg/fsroot/**                                 51 occurrences
    plan/root_binding_test.go                     the RUN root
    TestRun_BindsPendingResourcesToTheRunRoot
    TestGlob_RefusesPatternsOutsideTheRoot        the scoped root
    TestNewRuntimeEnvironment_MintsRootFromAnchor
    TestLintCommands_LoadConfigFromGitRoot        the git root

  Verified untouched by their absence from this diff, which is the only way a table of
  changes can distinguish "correctly unchanged" from "missed".

One correction to the issue's acceptance
  It asks that "the two historical notes survive". Only one still NAMES the retired
  identifiers -- receiver_type.go, explaining why ProviderRole, RoleAction, and
  Dispatch() went stale. The receiver_registry.go note survives as a note but was
  rewritten in current vocabulary during #715, so it records the doc correction without
  naming dead symbols. Better, but the acceptance implied two and there is one.
@David-Noble-at-work David-Noble-at-work self-assigned this Aug 28, 2026
@David-Noble-at-work
David-Noble-at-work merged commit 73724ed into develop Aug 28, 2026
12 checks passed
@David-Noble-at-work
David-Noble-at-work deleted the placement-vocabulary branch August 28, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename the last artifacts carrying retired placement vocabulary

1 participant