Repository navigation
fix(devlore-test): three fixtures assert text the runtime no longer produces (#875) - #878
Merged
Merged
Conversation
added 2 commits
September 9, 2026 19:32
…roduces (#875) Each failed when run through the CLI on develop; none is run by CI, so the rot was invisible. - test_imm_shell.star asserted shell.exec(...) == "echo hello" under the comment "returns the command string, not stdout". The value is a *shell.Result whose fields are individually reachable by reflection; it renders as "Result". Rewritten to assert command/stdout/stderr/exit_code, both streams, and the render. - test_flow_fatal_recovery.star asserted "fatal: abort after write"; the fatal action was renamed failed and the runtime emits "flow.failed executed: abort after write". - test_imm_file_join_variadic_error.star asserted "positional and keyword"; Starlark itself raises the refusal, worded 'multiple values for argument "parts"'. Harvested from the dead branch feature/shell-exec-product, whose only remaining value was these uncommitted corrections. All three pass through devlore-test run, before harvest and after. Why CI never caught it -- nothing runs the 110 non-Go-referenced data/*.star fixtures -- is #876, a harness gate, not a fixture edit. These corrections are to the current provider; the shell-provider rewrite (#799) will restate test_imm_shell.star, and a false test should not wait on that redesign. Claude-Session: https://claude.ai/code/session_01BTCnSyUbYFFUKMD3PuF1vt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #875.
Three
data/*.starfixtures assert text the runtime stopped producing. Each fails when run through the CLI ondevelop— the runtime is right, the fixtures are stale.test_imm_shell.starshell.exec(...) == "echo hello"*Resultrendering as"Result"; fields reached individuallytest_flow_fatal_recovery.star"fatal: abort after write""flow.failed executed: abort after write"(fatal→failed)test_imm_file_join_variadic_error.star"positional and keyword"'multiple values for argument "parts"'(Starlark's own)test_imm_shell.staris rewritten to assert the four fields, both streams, and the render, replacing one false scalar equality and a comment that stated the contract backwards.CI green is not the evidence here
Nothing in CI runs these fixtures — that is #876. The evidence is the CLI:
All three pass through
devlore-test runon this branch; all three fail ondevelop.Provenance and scope
Harvested from
feature/shell-exec-product(a dead branch — 0 ahead of develop, its only value these uncommitted corrections). Not the shell-provider rewrite: #799 will restatetest_imm_shell.star, but a false test should not wait on an open-ended redesign.Time
Computed by the algorithm of noblefactor-ops#188 at merge.