Repository navigation
fix(writ): the layer journey's post-move assertion names the orphans, not all of ~/local - #943
Merged
Merged
Conversation
… not all of ~/local Lane 1 (#922) rewrote step 3.4/3.5 to assert that, once the old links are removed by hand, the record says nothing about them. It swept every reconcile entry under ~/local. On Windows the later commit still deploys w.ps1 there, so a correct record failed the step and both Windows scenario jobs went red on develop at ec1d2c0. The assertion now names the orphans alone: the links the redeploy left dangling, the set the step already computes and removes. A target the later commit still deploys, re-pointed in place (the helper) or kept under ~/local (w.ps1), is rightly in the new record. `missing == 0` stays. Part of #916, lane 15. Claude-Session: https://claude.ai/code/session_01SqQVFZz7AdiLZkGoAcUqRW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR A′ of #916, lane 15: the Windows scenario regression
#940 left on develop.
Lane 1 rewrote the layer journey's step 3.4/3.5 to assert that, once the old links are removed by hand, the record
says nothing about them, and swept every reconcile entry under
~/localto say so. On Windows the later commit stilldeploys
w.ps1there, so a correct record failed the step;scenario (windows-amd64)andscenario (windows-arm64)have been red on develop since
ec1d2c0a.The assertion now names the orphans alone: the links the redeploy left dangling, the set the step already computes
and removes by hand. A target the later commit still deploys, re-pointed in place (the helper, whose source moved to
the base layer) or kept under
~/local(Windows'w.ps1), is rightly in the new record. Themissing == 0checkstays.
Closes #941
Evidence
Test code only; no shipped code changes.
make checkandmake test-scenariogreen on darwin/arm64 before opening;the pre-flight above runs CI's own gate on the merged tree. The Windows proof is this PR's two
scenario (windows-*)jobs, non-blocking but read before merge.
Test plan
make check,make test-scenariolocallyscenario (windows-amd64)andscenario (windows-arm64)green on this PRTime
Computed by the algorithm of noblefactor-ops#188 at merge.
https://claude.ai/code/session_01SqQVFZz7AdiLZkGoAcUqRW