Repository navigation
fix(security): bind OIDC providers to trusted tenants - #179
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind every catalog-backed OIDC provider and static JWT provider to an explicit, trusted NodeDB tenant. Authentication now derives the session tenant from provider configuration rather than the token's
tenant_idclaim.Security behavior
DDL and configuration
CREATE OIDC PROVIDERnow requiresTENANT <id>, persists the binding, validates the referenced tenant, and exposes it throughSHOW OIDC PROVIDERS.Static providers now require
tenant_idinauth.jwt.providers. Missing bindings fail startup validation rather than falling back to token claims.Compatibility
Persisted catalog records remain deserializable through an optional compatibility field, but unbound records fail authentication until recreated with an explicit tenant. This intentionally fails closed.
Validation