Skip to content

Remove un used parameters - #6719

Merged
nkolev92 merged 8 commits into
NuGet:devfrom
SimonCropp:remove-un-used-parameters
Sep 30, 2025
Merged

nkolev92 merged 8 commits into
NuGet:devfrom
SimonCropp:remove-un-used-parameters

Conversation

@SimonCropp

Copy link
Copy Markdown
Contributor

Bug

Fixes:

Description

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@SimonCropp
SimonCropp requested a review from a team as a code owner August 16, 2025 01:40
@dotnet-policy-service dotnet-policy-service Bot added the Community PRs created by someone not in the NuGet team label Aug 16, 2025
@nkolev92

Copy link
Copy Markdown
Member

There's some formatting failures.

The public CI has those details.

@nkolev92 nkolev92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
They are in test code, so cheap to change.
However, there's some failures, please take a look

@dotnet-policy-service dotnet-policy-service Bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Aug 25, 2025
@aortiz-msft

Copy link
Copy Markdown
Contributor

@SimonCropp - Do you think you'll be able to look at the test failures?

@dotnet-policy-service dotnet-policy-service Bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 2, 2025
@aortiz-msft aortiz-msft added the Merge next release PRs that should not be merged until the dev branch targets the next release label Sep 8, 2025
@dotnet-policy-service dotnet-policy-service Bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 15, 2025
@dotnet-policy-service dotnet-policy-service Bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 16, 2025
@dotnet-policy-service dotnet-policy-service Bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 23, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 30 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@dotnet-policy-service dotnet-policy-service Bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Sep 30, 2025
@nkolev92
nkolev92 enabled auto-merge (squash) September 30, 2025 23:02
@nkolev92
nkolev92 merged commit 451f81e into NuGet:dev Sep 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PRs created by someone not in the NuGet team Merge next release PRs that should not be merged until the dev branch targets the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants