Repository navigation
Stop loading esproj in VS - #6795
Merged
Merged
Conversation
jeffkl
approved these changes
Sep 23, 2025
donnie-msft
approved these changes
Sep 23, 2025
zivkan
approved these changes
Sep 23, 2025
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Related: NuGet/Home#13512
Description
esproj may sometimes have a project.json but that project.json is not the NuGet project.json.
To prevent misdetection in VS, we explicitly exclude esproj from getting detected as a project.json.
We have already allow listed esproj in some places so this is just continuation of that to prevent attempts to migrate projects that simply are not project.json projects and hit other potential issues like NuGet/Home#14553
PR Checklist
Added testsUnfortunately this is a non-standard test thatLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.