Skip to content

Send telemetry for legacy package directory usage, remove RestoreArgs.IsLowercaseGlobalPackagesFolder - #6800

Merged
nkolev92 merged 2 commits into
devfrom
dev-nkolev92-legacypackagedirectoryusage
Sep 23, 2025
Merged

nkolev92 merged 2 commits into
devfrom
dev-nkolev92-legacypackagedirectoryusage

Conversation

@nkolev92

@nkolev92 nkolev92 commented Sep 23, 2025 •

Copy link
Copy Markdown
Member

Bug

Related: NuGet/Home#14541

Description

RestoreLegacyPackagesDirectory is very likely unused and as mentioned in the issue, we should remove it.
The way to confirm that is get some telemetry so that's what this PR does.

I am also removing the RestoreArgs option that's not used in our code at all.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@nkolev92
nkolev92 requested a review from a team as a code owner September 23, 2025 21:24
jeffkl
jeffkl previously approved these changes Sep 23, 2025

@jeffkl jeffkl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does more than just add e

@nkolev92 nkolev92 changed the title Send telemetry for legacy package directory usage Send telemetry for legacy package directory usage, remove RestoreArgs.IsLowercaseGlobalPackagesFolder Sep 23, 2025
@nkolev92

Copy link
Copy Markdown
Member Author

@jeffkl yep, I had added it in the description, but I added it to the title as well.

@nkolev92
nkolev92 merged commit 4c2f5c5 into dev Sep 23, 2025
17 of 18 checks passed
@nkolev92
nkolev92 deleted the dev-nkolev92-legacypackagedirectoryusage branch September 23, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants