Repository navigation
Add alias to LockFileTarget and IRestoreTargetGraph, pivot based on alias in restore - #6805
Merged
nkolev92 merged 4 commits intoOct 2, 2025
Merged
Conversation
nkolev92
force-pushed
the
dev-nkolev92-addAliasToLockFileFormatAndTargetGraph
branch
from
September 29, 2025 19:27
9596d57 to
005c96b
Compare
nkolev92
marked this pull request as ready for review
September 30, 2025 22:11
nkolev92
force-pushed
the
dev-nkolev92-addAliasToLockFileFormatAndTargetGraph
branch
from
October 1, 2025 21:44
9f6953a to
48067c4
Compare
nkolev92
force-pushed
the
dev-nkolev92-addAliasToLockFileFormatAndTargetGraph
branch
from
October 2, 2025 00:42
48067c4 to
32aa481
Compare
zivkan
previously approved these changes
Oct 2, 2025
jeffkl
reviewed
Oct 2, 2025
jeffkl
approved these changes
Oct 2, 2025
nkolev92
enabled auto-merge (squash)
October 2, 2025 17:56
nkolev92
deleted the
dev-nkolev92-addAliasToLockFileFormatAndTargetGraph
branch
October 2, 2025 18:40
This was referenced Nov 6, 2025
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14577
Description
The full implementation of aliasing allows multiple
TargetFrameworkwith the same effective tfm.In order to achieve that, we will need to change up a bunch of the NuGet internal types to be identifiable by TargetAlias as well.
In this PR, I migrate our multiplexing to aliasing and attaching alias to 2 types that will inevitably need it, which is:
LockFileTarget, the type that expresses the targets element in the assets file, which is currently pivoted off the effective TFM full name.This is important because it allows everyone to depend on the TargetAlias regardless of what the lock file format itself is.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.