Repository navigation
Create PackageSpec type and helpers for project.json Migration - #6826
Merged
Merged
Conversation
nkolev92
reviewed
Oct 2, 2025
nkolev92
approved these changes
Oct 3, 2025
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3200
Fixes: https://github.com/NuGet/Client.Engineering/issues/3201
Description
Enables Visual Studio to migrate project.json projects without being directly tied to Restore via
PackageSpec.Creates a narrow PackageSpec type as a representation of a project.json migration candidate.
Copies relevant JSON parsing methods and other helper methods to read the 3 important properties:
Validation
Unit tests added covering
ProjectJsonMigrationCandidatePackageSpecReaderTestswhich are similar to and adapted from tests inNuGet.ProjectModel.Test.JsonPackageSpecReaderTests.Manually migrated a project.json project:
Tried multiple TargetFrameworks in a project.json to ensure an error is shown:
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.