Repository navigation
dotnet package update should work with any project references - #6846
Merged
Merged
Conversation
martinrrm
approved these changes
Oct 8, 2025
8 of 13 tasks
nkolev92
approved these changes
Oct 9, 2025
This was referenced Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14585
Description
Fix
dotnet package updateso that it works with any project references.The DependencyGraphSpec data strcuture, used for restore, needs the complete list of projects used by the "current project''s transitive project graph. The very earliest implementation of the command was only tested with a project without project references. When support for projects with project references was added, it assumed the "current project" would be first in the list, but it's not, the list is sorted alphabetically.
The test was modified to have the same scenario, so the project to update is no longer first in the sorted projects list. Running the test before the product changes validates the test catches the bug, and fixing the product code makes the test green again.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/A