Skip to content

Fix broken functions - #11

Closed
someonewithpc wants to merge 1 commit into
pivaldi:masterfrom
someonewithpc:master
Closed

someonewithpc wants to merge 1 commit into
pivaldi:masterfrom
someonewithpc:master

Conversation

@someonewithpc

Copy link
Copy Markdown

In my case, most of this mode wasn't working. I removed the patch functionality and instead directly have php-cs-fixer fix the current file, and then revert-buffer.

@pivaldi

pivaldi commented Mar 17, 2020

Copy link
Copy Markdown
Owner

This change is very intrusive while this mode works nicely in my case and, apparently, in most of the cases.
I can't accept your "barbaric" solution, sorry :)

@pivaldi pivaldi closed this Mar 17, 2020
@someonewithpc

Copy link
Copy Markdown
Author

Fair enough, though I'll note that the temp file function you're using creates a directory instead of a file, which doesn't seem to be what you want. Also, it'd be nice to expand-file-name the config file path, so one can use ~/.php_cs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants