Skip to content

fix: Loading OIDC profile pictures - #250

Merged
alex289 merged 4 commits into
mainfrom
fix/oidc_profile_pictures
Jul 20, 2026
Merged

alex289 merged 4 commits into
mainfrom
fix/oidc_profile_pictures

Conversation

@alex289

@alex289 alex289 commented Jul 19, 2026

Copy link
Copy Markdown
Member

Type of change

  • 🐛 Bug fix
  • 🚀 New feature
  • ❓ Other (please specify)

Description

Loading the image 'https://oidc/api/users/userId/profile-picture.png' violates the following Content Security Policy directive: "img-src 'self' data:". The action has been blocked.

This fix proxies the image. Since the providers are dynamically configureable it was the only way possible instead of making the CSP softer

@alex289
alex289 requested a review from timokoessler July 19, 2026 21:51
@alex289 alex289 self-assigned this Jul 19, 2026
@alex289 alex289 added the enhancement New feature or request label Jul 19, 2026
@codecov

codecov Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.11628% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/internal/hub/routes/profile_picture.go 62.50% 10 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

@timokoessler timokoessler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

Comment thread backend/internal/hub/routes/profile_picture.go Outdated
@alex289
alex289 requested a review from timokoessler July 20, 2026 08:32
@alex289
alex289 enabled auto-merge (squash) July 20, 2026 08:32
Comment thread backend/internal/hub/routes/profile_picture.go Outdated
@alex289
alex289 requested a review from timokoessler July 20, 2026 09:30
@alex289
alex289 merged commit 81c49b5 into main Jul 20, 2026
10 of 11 checks passed
@alex289
alex289 deleted the fix/oidc_profile_pictures branch July 20, 2026 09:35
@orcacd-bot orcacd-bot Bot mentioned this pull request Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend enhancement New feature or request hub

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants