Repository navigation
feat: Enhance handshake security (Breaking Change) - #269
Merged
Merged
Conversation
By signing the agent response with a long term pre-shared key. This prevents a man in the middle reading the auth token header to spoof the connection.
alex289
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Enhance handshake security by signing the agent response with a long term pre-shared key. This prevents a man in the middle reading the auth token header to spoof the connection. Before it was already not possible to spoof the hub, but a agent could be spoofed if a malicious actor could get in the middle of the websocket connection during a handshake.
Additional context
This requires all Agent tokens to be re-issued!!!