[Bug] Get-ADTShortcut hits an error when icon path contains an environment variable #1709

Prerequisites

• Ensure you write a short, descriptive title after [Bug] above.
• Make sure to search for any existing issues before filing a new one.
• Verify you are able to reproduce the issue with the latest released version

PSAppDeployToolkit version

4.1.4 dev

Describe the bug

Retrieving shortcut details can fail with error such as:

[Execution] [Get-ADTShortcut] [Error] :: Failed to read the shortcut [C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Accessibility\Speech Recognition.lnk]. Exception calling ".ctor" with "10" argument(s): "Invalid icon location path provided."

Steps to reproduce

Get-ChildItem $envCommonStartMenuPrograms -Recurse | % {Get-ADTShortcut $_.FullName}

Environment data

💾