Avoid Get-Acl/Set-Acl cmdlets in PowerShell as they have inappropriate permissions testing. - #1692
Merged
Merged
Conversation
…opriate permissions testing. Fixes #1691.
…ableInheritance` pathway.
mjr4077au
force-pushed
the
setAdtItemPermission
branch
from
September 2, 2025 04:21
7ddb886 to
4baca77
Compare
Contributor
|
FYI: The security methods of DirectoryInfo and FileInfo have been moved into a different namespace in powershell core and are now extension methods in FileSystemAclExtensions. |
Member
Author
|
@neo42JBR this should still be fine as we do the exact same setup in our C# code and this dual-compiles as |
Member
Author
|
Oh I see, it's an actual extension method which won't work in PowerShell. Onto it. |
Member
Author
DanGough
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1691.