Conversation
Pretty much all of the changes are to do with incorrect document comments.
…malformed input.
…rror capturing better.
…CsWin32's doesn't have `SetLastError = true`.
… in CsWin32. This actually half-way implements #1543 for us, so that's a win I suppose!
…GetEffectiveAccess()`.
…ssImageName()`. This will now print the char array so we can debug the raw values if required.
….GetRunningProcesses()`.
… so we can add more detail. Fixes #1899.
… MSI deployments. Initially this was unset to make the InstallTitle read better. It's better that it be set and the InstallName/InstallTitle generation factor it in. Fixes #1883.
3 tasks
This is to stop the rug from being pulled out under us where the object is constructed with a worldview of x but it ends up being y. Fixes #1890.
DanGough
self-requested a review
November 26, 2025 16:31
DanGough
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SafeMemoryHandletypes #1540Span<T>andMemoryMarshal.Read<T>()in more places. #1543