Repository navigation
Major review of sdlstdinc.inc (from SDL_stdinc.h) necessary #62
Description
Activity
I've been updating some of the other
.incfiles and some of original.hfiles contain macros / inline functions that make use of stuff declared inSDL_stdinc.h. I'm wondering how to approach this.-
A) Wherever possible, use FPC's built-in functions, instead. If not possible, declare the SDL functions in
sdl2.pasin the implementation section, so they're not exposed to the user. -
B) Declare the SDL functions as usual inside
sdlstdinc.hand just live with the fact that there's only a select few of them declared. -
C) Go all-in and try to translate as much of the "SDL libc" functions as possible.
-
Free-Pascal-meets-SDL-Website commented
on Feb 1, 2023 CollaboratorAuthorA) - In certain cases A) may be suitable, if compatibility is not affected. A hinting FIXME-comment should note about the used functions.
B) - I think this is the best option, because we want our units to be as Delphi compatible as possible, which is not guaranteed for option A). Also, some compiler functions may need additional units which increase dependencies, which is undesirable.
C) - We do not necessarily need all the "SDL libc" functions, so we do not need to waste time in translating and maintaining them.
What do you think? @suve
The C header file
SDL_stdinc.hcontains a lot of functions, types and features which are not found in the correspondingsdlstdinc.inc.A major review of this file is necessary: