Repository navigation
Bump minimum version of matplotlib and enable matplotlib 3.5.0 - #1334
Merged
Merged
Conversation
The nonposy keyword was removed in matplotlib 3.5.0 and replaced with nonpositive.
github-actions
Bot
added
the
plasmapy.diagnostics
Codecov Report
@@ Coverage Diff @@
## main #1334 +/- ##
=======================================
Coverage 97.09% 97.09%
=======================================
Files 73 73
Lines 7165 7165
=======================================
Hits 6957 6957
Misses 208 208
Continue to review full report at Codecov.
|
namurphy
added
Availability
requirements
StanczakDominik
enabled auto-merge (squash)
November 18, 2021 09:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nonposykeyword was removed from matplotlib 3.5.0, and replaced withnonpositivewhich was added in matplotlib 3.3.0. The easiest fix was to replacenonposywithnonpositiveand bump the minimum version of matplotlib from 3.2.0 to 3.3.0.If we wanted to stay compatible with matplotlib 3.2.0, an alternative would be to put a
try/exceptclause to catch theTypeError. I don't prefer that approach because that fix is less permanent.