Repository navigation
fix for metadata disk graphs - #2114
Merged
Merged
Conversation
rachchan
force-pushed
the
fix/metadatadiskgraph
branch
from
June 10, 2025 14:12
deef00c to
a01fadd
Compare
miratepuffin
approved these changes
Jun 10, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 30f437d | Previous: e98833a | Ratio |
|---|---|---|---|
lotr_graph_window_100/num_edges |
26 ns/iter (± 0) |
6 ns/iter (± 0) |
4.33 |
This comment was automatically generated by workflow using github-action-benchmark.
miratepuffin
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
read_metadata can read disk graphs
Why are the changes needed?
metadata in graphql wasn't working for disk graph data
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?