Skip to content

Features/gql filters - #2126

Merged
shivamka1 merged 5 commits into
masterfrom
features/gql_filters
Jun 17, 2025
Merged

Features/gql filters#2126
shivamka1 merged 5 commits into
masterfrom
features/gql_filters

Conversation

@shivamka1

@shivamka1 shivamka1 commented Jun 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Impl validate operator value pair

gql query:

query {
  graph(path: "master") {
    nodeFilter(filter: {
      property: {
        name: "p10"
        operator: CONTAINS
        value: { u64: 2 }
      }
    }) {
      nodes {
        list {
          name
        }
      }
    }
  }
}

returns

{
  "data": null,
  "errors": [
    {
      "message": "Invalid filter: Operator CONTAINS requires a string value, got U64(2)",
      "locations": [
        {
          "line": 3,
          "column": 5
        }
      ]
    }
  ]
}

@shivamka1
shivamka1 marked this pull request as ready for review June 17, 2025 10:53
ljeub-pometry
ljeub-pometry requested changes Jun 17, 2025
View reviewed changes
Comment thread python/tests/test_base_install/test_graphql/test_filters/test_graph_edges_property_filter.py Outdated
Comment thread python/tests/test_base_install/test_graphql/test_filters/test_graph_edges_property_filter.py
Comment thread raphtory-graphql/src/model/graph/filtering.rs Outdated
Comment thread raphtory-graphql/src/model/graph/filtering.rs Outdated
Comment thread raphtory-graphql/src/model/graph/filtering.rs Outdated
Comment thread raphtory-graphql/src/model/graph/filtering.rs Outdated
Comment thread raphtory-graphql/src/model/graph/filtering.rs Outdated
Comment thread raphtory-graphql/src/model/graph/property.rs Outdated
Comment thread raphtory-graphql/src/model/graph/property.rs Outdated
ljeub-pometry
ljeub-pometry approved these changes Jun 17, 2025
View reviewed changes

@ljeub-pometry ljeub-pometry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@shivamka1
shivamka1 merged commit 3e0b869 into master Jun 17, 2025
@shivamka1
shivamka1 deleted the features/gql_filters branch June 17, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljeub-pometry ljeub-pometry ljeub-pometry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivamka1 @ljeub-pometry