WIP - Test with real ConsoleKeyInfo values - #838

A couple of questions:
when it say

Enter <w>:
Enter <V>:

CAPS, V or Shift+v ?

Enter <Ctrl+C>:

CAPS, Ctrl+C or Ctrl+c or Shift+Ctrl+c ?

there is

Enter Ctrl+c
Enter Ctrl+C

should I use the same combination or press Shift for second ? and many others that exists only with shift

Enter is a gray Enter ? on primary it say "double check', and for <Ctrl+Alt+?> too (may be because ? is a Shift+/ )

for /, *, -, + should I use Shift combinations or gray keyboard ?

btw, [CmdletBindingAttribute()] is a typo or something latest PSv6 specific ?

Max Kozlov (@MVKozlov) - thanks for giving this a go.

It looks like for regular keys, Caps Lock and Shift should work identically, so either is fine and it will be good to test without Shift.

For control keys, it looks Caps Lock,Ctrl+a does not turn into Ctrl+A, so avoid Caps Lock for modified keys.

If you get the message double check, don't worry too much about that. The intent is to catch typos, but that logic is dependent on possibly buggy logic in PSReadLine. If you enter the same key twice, it accepts it as correct and moves on.

For symbols, I suggest using the most natural keys. If you're not too sure, then I suggest not using the numeric keypad as laptops often don't have those keys.

And regarding CmdletBindingAttribute, that's always been supported, I didn't realize I typed out the full type name. By convention, attributes use the suffix Attribute and languages like C# or PowerShell can resolve the type name when used as an attribute with or without the suffix. PowerShell goes a bit further since V3 an resolves the name when used as a type (e.g. 'CmdletBinding' -as [Type]), whereas in C# you'd have to write typeof(CmdletBindingAttribute).

You do not say a word about duplicates - Ctrl+C and Ctrl+c - should I use Shift+Ctrl+c for first. I think I should

Caps Lock and Shift can work differently at least at PSRealine :), see #798
I try to use CAPS.

So, I make PR when i finished with it.

and about attribute:

PS D:\> D:\Work\PSReadLine\test\Get-KeyInfoData.ps1
Cannot find the type for custom attribute 'CmdletBindingAttribute'. Make sure that the assembly that contains this type is loaded
.
At D:\Work\PSReadLine\test\Get-KeyInfoData.ps1:1 char:1
+ [CmdletBindingAttribute()]
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: ([CmdletBindingAttribute()]:AttributeAst) [], RuntimeException
    + FullyQualifiedErrorId : CustomAttributeTypeNotFound

PS D:\> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.14409.1012
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14409.1012
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

but with [CmdletBinding()] its OK

PR #839

Thanks Max Kozlov (@MVKozlov). [CmdetBindingAttribute()] worked for me because of something I have in my profile. I fixed the script so nobody else will hit the same thing.

Can I ask how you entered the English characters? Alt+numpad? Switch layouts? Or is there another way?

After I work out how to best run the tests with different layouts, we'll start adding language specific tests, so for example we can make sure Cyrillic characters work properly, and make sure you can enter other characters like ã or à or â correctly.

There is a bug in a Win32 api that I'm using that doesn't correctly handle keyboard layout changes. It doesn't affect too many key bindings, but it definitely affects running the tests, so I need to figure out a way to run the tests where the keyboard layout is changed before launching the test runner and the test runner only tests a single language.

I switched to US layout but if need I can collect Cyrillic key info on the same keys with Cyrillic layout (but seems I will need to enter every key twice :)

Jason Shirk (@lzybkr), so there is need to repeat collecting console info with cyrillic layout switched on ?

PR #870