Skip to content

Publish-Module should support PSModuleInfo as input #92

Description

@jianyunt

From Heath Stewart (@heaths) on November 2, 2015 22:32

I have a help file in my module named something like mydll.dll-help.xml and it works fine when in the module directory; however, after running publish-module it seems that file wasn't packaged and pulled down later with install-module. The file is listed in the module manifest in the FileList property.

See the 'msi' module in the gallery if you want to review the manifest.

Copied from original issue: OneGet/oneget#155

Activity

  1. jianyunt commented on Nov 3, 2016

    @jianyunt
    Author

    From Heath Stewart (@heaths) on November 25, 2015 1:16

    Upon further investigation, piping a PSModuleInfo object to Publish-Module actually binds to the Name parameter, which causes Publish-Module to look up the module, which in my case didn't have the help XML because the original uploaded module didn't have it.

    When using the Path parameter, there is a bug that assumes that the parent directory name of the .psd1 file is the module name (instead of, logically, the name of the file). But when building projects, the parent directory name is likely 'Debug' or 'Release'. This needs to be fixed.

    When debugging this, if I change $manifestPath in Publish-Module, the scenario works correctly...though one may want to (optionally) exclude files like *.pdb.

    I will try to get a PR for this, but given the dependency on having the PowerShellGet module I may just construct the NuPkg myself for my project so I don't need to install additional dependencies via AppVeyor.

  2. jianyunt commented on Nov 3, 2016

    @jianyunt
    Author

    From Quoc Truong (@quoctruong) on November 25, 2015 4:53

    Hi heaths, thanks for investigating the bugs. I will point this out to the owner of the PowerShellGet module (this repository is mostly for PackageManagement work, we don't have a repository for PowerShellGet yet).

  3. changed the title [-]Publish-Module doesn't seem to publish help[/-] [+]Publish-Module should support PSModuleInfo as input[/+] on Nov 4, 2016
  4. added this to the vNext milestone on Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions