Skip to content

Tests on windows should not fail, when they run in non-elevated (non admin) env  #1486

Closed

Description

@vors

There is a number of tests (mostly in PackageManager) that are failing, when they run without admin priviledges. Our CI doesn't catch it, because it's run elevated. But we should have a good experience for developers: they should be able to run it locally without elevation and see clean results on the build from master.

Activity

  1. changed the title [-]Tests on windows should not fail, when they run in non-elevated env [/-] [+]Tests on windows should not fail, when they run in non-elevated (non admin) env [/+] on Jul 22, 2016
  2. modified the milestone: on Aug 4, 2016
  3. modified the milestones: 6.0.0-alpha.10, on Sep 10, 2016
  4. vors commented on Sep 10, 2016

    @vors
    CollaboratorAuthor

    My current proposition about it:

    1. Introduce a new tag for Pester tests (i.e. "RequireAdmin").
      Mark tests that absolutely has to be admin with this tag.
      Change the rest of the tests to avoid requiring admin privileges.
    2. In the AppVeyor CI split CoreCLR test run into two parts:
      • -ExcludeTag 'RequireAdmin' (this should be executed with down-graded elevation, for example )
      • -Tag 'RequireAdmin' with normal admin priviledges

    Thoughts? cc Steve Lee (@SteveL-MSFT) James Truher (@JamesWTruher) Andy Jordan (@andschwa) Jason Shirk (@lzybkr)

  5. SteveL-MSFT commented on Sep 12, 2016

    @SteveL-MSFT
    Member

    Seems reasonable. Generally speaking, we shouldn't require admin for anything that doesn't require admin including running tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Issue-Metaan issue used to track multiple issuesResolution-FixedThe issue is fixed.WG-Quality-Testissues in a test or in test infrastructure

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions